Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](ES catalog)Doris cannot parse ES date field without time zone #24864

Merged
merged 6 commits into from
Oct 8, 2023

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Sep 25, 2023

Proposed changes

Issue Number: close #24863

  1. Add support for Doris to parse ES date field without time zone info. eg: 2023-04-17T23:01:18.151, this time will be treated as UTC time, since ES assumes that the time zone for time fields without time zones is UTC.
  2. Change local time zone convertion from system local time zone to session variable time zone.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@qidaye
Copy link
Contributor Author

qidaye commented Sep 25, 2023

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@qidaye
Copy link
Contributor Author

qidaye commented Sep 25, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.17% (8024/22182)
Line Coverage: 28.50% (64459/226178)
Region Coverage: 27.39% (33494/122303)
Branch Coverage: 24.07% (17130/71162)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dee4ff77717daa4dde1ba062e199ae184a538f13_dee4ff77717daa4dde1ba062e199ae184a538f13/report/index.html

@qidaye
Copy link
Contributor Author

qidaye commented Sep 25, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.32% (8113/22336)
Line Coverage: 28.44% (64897/228165)
Region Coverage: 27.33% (33656/123132)
Branch Coverage: 23.98% (17175/71624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dee4ff77717daa4dde1ba062e199ae184a538f13_dee4ff77717daa4dde1ba062e199ae184a538f13/report/index.html

@qidaye
Copy link
Contributor Author

qidaye commented Sep 26, 2023

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.43% (8156/22388)
Line Coverage: 28.55% (65348/228872)
Region Coverage: 27.41% (33856/123515)
Branch Coverage: 24.05% (17276/71832)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5dfdefccddd4959588c2126845691ba98cd3b743_5dfdefccddd4959588c2126845691ba98cd3b743/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.09 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162074064 Bytes

@qidaye qidaye force-pushed the es_datetime_error branch from 5dfdefc to 11d0d51 Compare October 7, 2023 11:50
@qidaye
Copy link
Contributor Author

qidaye commented Oct 7, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8151/22458)
Line Coverage: 28.41% (65173/229425)
Region Coverage: 27.35% (33761/123431)
Branch Coverage: 24.02% (17216/71686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/11d0d514cf3a37b149957966db47d94f111e4a64_11d0d514cf3a37b149957966db47d94f111e4a64/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.53 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162206754 Bytes

@qidaye qidaye force-pushed the es_datetime_error branch from 11d0d51 to a8ba5be Compare October 8, 2023 03:56
@qidaye
Copy link
Contributor Author

qidaye commented Oct 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8151/22458)
Line Coverage: 28.42% (65188/229339)
Region Coverage: 27.35% (33781/123500)
Branch Coverage: 24.04% (17221/71648)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a8ba5bef01bf346222356626ef1cb10e52c20c01_a8ba5bef01bf346222356626ef1cb10e52c20c01/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.48 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162357204 Bytes

@qidaye qidaye force-pushed the es_datetime_error branch from a8ba5be to 3557f2a Compare October 8, 2023 08:22
@qidaye
Copy link
Contributor Author

qidaye commented Oct 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (8149/22458)
Line Coverage: 28.42% (65172/229339)
Region Coverage: 27.34% (33768/123500)
Branch Coverage: 24.02% (17210/71648)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3557f2af4516d2fc087bf8879e848e918a18d7d9_3557f2af4516d2fc087bf8879e848e918a18d7d9/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.74 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162207896 Bytes

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@SaintBacchus SaintBacchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit 7e9ffad into apache:master Oct 8, 2023
@qidaye qidaye deleted the es_datetime_error branch October 8, 2023 11:28
xiaokang pushed a commit that referenced this pull request Oct 8, 2023
…24864)

1. Add support for Doris to parse ES date field without time zone info. eg: `2023-04-17T23:01:18.151`, this time will be treated as UTC time, since ES assumes that the time zone for time fields without time zones is UTC.
2. Change local time zone convertion from system local time zone to session variable time zone.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…pache#24864)

1. Add support for Doris to parse ES date field without time zone info. eg: `2023-04-17T23:01:18.151`, this time will be treated as UTC time, since ES assumes that the time zone for time fields without time zones is UTC.
2. Change local time zone convertion from system local time zone to session variable time zone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] es catalog parse field error
5 participants