-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve](metric) Improve FE DorisMetricRegistry #24773
Conversation
The current implementation needs to iterate all metrics in a lock, which might cause latency spikes. This PR changes the underlying data structure to ConcurrentHashMap so that removing metrics doesn't need to block the entire registry.
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
The current implementation needs to iterate all metrics in a lock, which might cause latency spikes. This PR changes the underlying data structure to ConcurrentHashMap so that removing metrics doesn't need to block the entire registry.
The current implementation needs to iterate all metrics in a lock, which might cause latency spikes. This PR changes the underlying data structure to ConcurrentHashMap so that removing metrics doesn't need to block the entire registry.