Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](index compaction)ignore doc which dose not exist in destination segment #24729

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Sep 21, 2023

Proposed changes

Issue Number: close #24728

In the unique key mow table, compaction will merge identical keys, ultimately leading to docs being deleted in the output segment files. Index compaction needs to ignore deleted rows.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@qidaye
Copy link
Contributor Author

qidaye commented Sep 21, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.58 seconds
stream load tsv: 597 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162160407 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.42% (8021/22026)
Line Coverage: 28.70% (64393/224370)
Region Coverage: 27.60% (33432/121147)
Branch Coverage: 24.26% (17109/70538)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b3bc6a2dfa529e526120fd77708646ff2c846e79_b3bc6a2dfa529e526120fd77708646ff2c846e79/report/index.html

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang added usercase Important user case type label dev/2.0.2 labels Sep 21, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 21, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@xiaokang xiaokang merged commit ec987b1 into apache:master Sep 21, 2023
@qidaye qidaye deleted the fix_index_compaction branch September 21, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] index compaction core
4 participants