Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](binlog) Add more log for ingest_binlog && Fix ingest_binlog not rewrite rowset_meta tablet_uid #24617

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[Fix](binlog) Add more log for ingest_binlog && Fix ingest_binlog not rewrite rowset_meta tablet_uid #24617

merged 2 commits into from
Sep 21, 2023

Conversation

JackDrogon
Copy link
Contributor

Proposed changes

Add more log for ingest_binlog && Fix ingest_binlog not rewrite rowset_meta tablet_uid

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@JackDrogon
Add more log for ingest_binlog && Fix ingest_binlog not rewrite
12b882c 
rowset_meta tablet_uid

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@JackDrogon
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 19, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.83% (7979/21667)
Line Coverage: 28.85% (64028/221940)
Region Coverage: 27.74% (33228/119779)
Branch Coverage: 24.36% (17029/69910)
Coverage Report: http://coverage.selectdb-in.cc/coverage/12b882c48f90f6979899732fe25535bd98f73215_12b882c48f90f6979899732fe25535bd98f73215/report/index.html

@JackDrogon
Add lost thrift TDebugProtocol
37259f7 
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
@JackDrogon
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.68% (7990/21785)
Line Coverage: 28.71% (64079/223232)
Region Coverage: 27.62% (33266/120458)
Branch Coverage: 24.24% (17045/70304)
Coverage Report: http://coverage.selectdb-in.cc/coverage/37259f7c1115ab662e1563ccc73799fb5ab89767_37259f7c1115ab662e1563ccc73799fb5ab89767/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.71 seconds
stream load tsv: 597 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162373639 Bytes

dataroaring
dataroaring approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 20, 2023
yiguolei
yiguolei approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit ee5b307 into apache:master Sep 21, 2023
xiaokang pushed a commit that referenced this pull request Sep 21, 2023
@JackDrogon @xiaokang
[Fix](binlog) Add more log for ingest_binlog && Fix ingest_binlog not…
832e18d 
… rewrite rowset_meta tablet_uid (#24617)

* Add more log for ingest_binlog && Fix ingest_binlog not rewrite
rowset_meta tablet_uid

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>

* Add lost thrift TDebugProtocol

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>

---------

Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
@xiaokang xiaokang mentioned this pull request Sep 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@ByteYue ByteYue ByteYue approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JackDrogon @doris-robot @yiguolei @ByteYue @dataroaring @xiaokang