Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](index compaction)skip index compaction when no output segment #24468

Merged
merged 2 commits into from
Sep 16, 2023
Merged

[fix](index compaction)skip index compaction when no output segment #24468

merged 2 commits into from
Sep 16, 2023

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Sep 15, 2023

Proposed changes

Issue Number: close #24466

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@qidaye
Copy link
Contributor Author

qidaye commented Sep 15, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.86% (7981/21654)
Line Coverage: 28.85% (63968/221707)
Region Coverage: 27.80% (33211/119482)
Branch Coverage: 24.39% (17041/69882)
Coverage Report: http://coverage.selectdb-in.cc/coverage/171cc336ce8d428ffde79968921241269dcf7aea_171cc336ce8d428ffde79968921241269dcf7aea/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.87 seconds
stream load tsv: 595 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162251581 Bytes

@xiaokang xiaokang added usercase Important user case type label dev/2.0.2 labels Sep 15, 2023
xiaokang
xiaokang approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 15, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaokang xiaokang merged commit 643d09d into apache:master Sep 16, 2023
xiaokang pushed a commit that referenced this pull request Sep 16, 2023
@qidaye @xiaokang
[fix](index compaction)skip index compaction when no output segment (#…
a85f33d 
…24468)
@qidaye qidaye deleted the index_compaction branch September 19, 2023 10:15
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Sep 19, 2023
@qidaye
[fix](index compaction)skip index compaction when no output segment (a…
83ece1c 
…pache#24468)

(cherry picked from commit 643d09d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokang xiaokang xiaokang approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged merge_conflict reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] index compaction core
4 participants
@qidaye @doris-robot @xiaokang @eldenmoon