[Enhancement](show-backends-disks) Add show backends disks #24229
Conversation
|
run buildall |
|
run clickbench |
|
run p0 |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 |
| ` | ||
| ### Keywords | ||
|
|
||
| SHOW, BACKENDS |
There was a problem hiding this comment.
SHOW, BACKENDS, DISK, DISKS
There was a problem hiding this comment.
I will add it when implementing corresponding tvf.
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
|
||
| ImmutableMap<String, DiskInfo> disksRef = backend.getDisks(); | ||
| for (DiskInfo disk : disksRef.values()) { | ||
| if (disk.getState() == DiskState.ONLINE) { |
There was a problem hiding this comment.
May be we should also show the offline disk. The offline disk is also reported from be to master. (Offline disk means the disk health check is bad). And we should add a column to show this disk's online/offline state.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
yongjinhou
force-pushed
the
show-backends-disks
branch
from
17d0f25 to
a938586
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run p0 |
1 similar comment
|
run p0 |
adonis0147
force-pushed
the
show-backends-disks
branch
from
752071f to
402de28
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
) * Add statement to query disk information corresponding to data directory of BE node [msyql]->'show backends disks;' +-----------+-------------+------------------------------+---------+----------+---------------+-------------+-------------------+---------+ | BackendId | Host | RootPath | DirType | DiskState| TotalCapacity | UsedCapacity| AvailableCapacity | UsedPct | +-----------+-------------+------------------------------+---------+----------+---------------+-------------+-------------------+---------+ | 10002 | 10.xx.xx.90 | /home/work/output/be/storage | STORAGE | ONLINE | 7.049 TB | 2.478 TB | 4.571 TB | 35.16 % | | 10002 | 10.xx.xx.90 | /home/work/output/be | DEPLOY | ONLINE | 7.049 TB | 2.478 TB | 4.571 TB | 35.16 % | | 10002 | 10.xx.xx.90 | /home/work/output/be/log | LOG | ONLINE | 7.049 TB | 2.478 TB | 4.571 TB | 35.16 % | +-----------+-------------+------------------------------+---------+----------+---------------+-------------+-------------------+---------+
…pache#24229)" (apache#25389) This reverts commit 21223e6.
…ry of BE node
Proposed changes
Issue Number: close #24226
Add statement to query disk information corresponding to data and log directory of BE node.
'show backends disks;'
+-----------+-------------+------------------------------+---------+----------+---------------+-------------+-------------------+---------+
| BackendId | Host | RootPath | DirType | DiskState| TotalCapacity | UsedCapacity| AvailableCapacity | UsedPct |
+-----------+-------------+------------------------------+---------+----------+---------------+-------------+-------------------+---------+
| 10002 | 10.xx.xx.90 | /home/work/output/be/storage | STORAGE | ONLINE | 7.049 TB | 2.478 TB | 4.571 TB | 35.16 % |
| 10002 | 10.xx.xx.90 | /home/work/output/be | DEPLOY | ONLINE | 7.049 TB | 2.478 TB | 4.571 TB | 35.16 % |
| 10002 | 10.xx.xx.90 | /home/work/output/be/log | LOG | ONLINE | 7.049 TB | 2.478 TB | 4.571 TB | 35.16 % |
+-----------+-------------+------------------------------+---------+----------+---------------+-------------+-------------------+---------+
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...