-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvemnt](script) support custom lib dir to save custom libs #23887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
(From new machine)TeamCity pipeline, clickbench performance test result: |
Sometimes, user need to add some custom libs to the cluster, such lzo.jar, orai18n.jar, etc. In previous, these lib files are places in fe/lib or be/lib. But when upgrading cluster, the lib dir will be replaced by new lib dir, so that all custom libs are lost. In this PR, I add new dir custom_lib for FE and BE, and user can place custom lib files in it.
Sometimes, user need to add some custom libs to the cluster, such lzo.jar, orai18n.jar, etc. In previous, these lib files are places in fe/lib or be/lib. But when upgrading cluster, the lib dir will be replaced by new lib dir, so that all custom libs are lost. In this PR, I add new dir custom_lib for FE and BE, and user can place custom lib files in it.
Proposed changes
Sometimes, user need to add some custom libs to the cluster, such lzo.jar, orai18n.jar, etc.
In previous, these lib files are places in
fe/lib
orbe/lib
.But when upgrading cluster, the
lib
dir will be replaced by newlib
dir, so that all custom libs are lost.In this PR, I add new dir
custom_lib
for FE and BE, and user can place custom lib files in it.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...