Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test](Framework) add enable cache data args for test CommandLine #21852

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

ZhangYu0123
Copy link
Contributor

Proposed changes

  1. add regression cache data args for test CommandLine
    Because enableCacheData param is not added to command line from this pr [Test][Framework] add enableCacheData option for test framework #20874, when use command line to test, it will always download s3 data again and fails many times.

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@ZhangYu0123
Copy link
Contributor Author

run buildall

@ZhangYu0123 ZhangYu0123 changed the title [Test](Framework) add cache data args for test CommandLine [Test](Framework) add enable cache data args for test CommandLine Jul 16, 2023
@ZhangYu0123
Copy link
Contributor Author

run p0

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

PR approved by at least one committer and no changes requested.

@dataroaring
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

PR approved by anyone and no changes requested.

@ZhangYu0123 ZhangYu0123 force-pushed the fix_regression_cache_data branch from abdfd32 to fc5d1b5 Compare September 3, 2023 02:55
@ZhangYu0123 ZhangYu0123 force-pushed the fix_regression_cache_data branch from fc5d1b5 to 7d484be Compare September 3, 2023 02:59
@dataroaring
Copy link
Contributor

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants