Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](multi-catalog) Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments. #21430

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented Jul 3, 2023

Proposed changes

Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…lve can not enable hadoop short circuit reading in some environments.
@kaka11chen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@zddr zddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 88b2d81 into apache:master Jul 3, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Jul 3, 2023
…lve can not enable hadoop short circuit reading in some environments. (apache#21430)

Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
morningman pushed a commit that referenced this pull request Jul 3, 2023
…lve can not enable hadoop short circuit reading in some environments. (#21430)

Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 3, 2023
xiaokang pushed a commit that referenced this pull request Jul 3, 2023
…lve can not enable hadoop short circuit reading in some environments. (#21430)

Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
morningman pushed a commit that referenced this pull request Jul 6, 2023
… in some environments. (#21548)

Merge #21516 to branch-1.2-lts.

Fix hadoop short circuit reading can not enabled in some environments.
- Revert #21430 because it will cause performance degradation issue.
- Add `$HADOOP_CONF_DIR` to `$CLASSPATH`.
- Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled.
- Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98
) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
morningman pushed a commit that referenced this pull request Jul 6, 2023
… in some environments. (#21516)

Fix hadoop short circuit reading can not enabled in some environments.
- Revert #21430 because it will cause performance degradation issue.
- Add `$HADOOP_CONF_DIR` to `$CLASSPATH`.
- Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled.
- Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98
) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
xiaokang pushed a commit that referenced this pull request Jul 6, 2023
… in some environments. (#21516)

Fix hadoop short circuit reading can not enabled in some environments.
- Revert #21430 because it will cause performance degradation issue.
- Add `$HADOOP_CONF_DIR` to `$CLASSPATH`.
- Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled.
- Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98
) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…lve can not enable hadoop short circuit reading in some environments. (apache#21430)

Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
… in some environments. (apache#21548)

Merge apache#21516 to branch-1.2-lts.

Fix hadoop short circuit reading can not enabled in some environments.
- Revert apache#21430 because it will cause performance degradation issue.
- Add `$HADOOP_CONF_DIR` to `$CLASSPATH`.
- Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled.
- Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98
) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
morningman pushed a commit that referenced this pull request Jul 19, 2023
… in some environments. (#21548)

Merge #21516 to branch-1.2-lts.

Fix hadoop short circuit reading can not enabled in some environments.
- Revert #21430 because it will cause performance degradation issue.
- Add `$HADOOP_CONF_DIR` to `$CLASSPATH`.
- Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled.
- Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98
) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.6-merged dev/2.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants