-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](multi-catalog) Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments. #21430
Merged
morningman
merged 1 commit into
apache:master
from
kaka11chen:add-hadoop_system_classpath
Jul 3, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lve can not enable hadoop short circuit reading in some environments.
run buildall |
morningman
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
zddr
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jul 3, 2023
…lve can not enable hadoop short circuit reading in some environments. (apache#21430) Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
morningman
pushed a commit
that referenced
this pull request
Jul 3, 2023
…lve can not enable hadoop short circuit reading in some environments. (#21430) Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
xiaokang
pushed a commit
that referenced
this pull request
Jul 3, 2023
…lve can not enable hadoop short circuit reading in some environments. (#21430) Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
morningman
pushed a commit
that referenced
this pull request
Jul 6, 2023
… in some environments. (#21548) Merge #21516 to branch-1.2-lts. Fix hadoop short circuit reading can not enabled in some environments. - Revert #21430 because it will cause performance degradation issue. - Add `$HADOOP_CONF_DIR` to `$CLASSPATH`. - Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled. - Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98 ) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
morningman
pushed a commit
that referenced
this pull request
Jul 6, 2023
… in some environments. (#21516) Fix hadoop short circuit reading can not enabled in some environments. - Revert #21430 because it will cause performance degradation issue. - Add `$HADOOP_CONF_DIR` to `$CLASSPATH`. - Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled. - Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98 ) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
xiaokang
pushed a commit
that referenced
this pull request
Jul 6, 2023
… in some environments. (#21516) Fix hadoop short circuit reading can not enabled in some environments. - Revert #21430 because it will cause performance degradation issue. - Add `$HADOOP_CONF_DIR` to `$CLASSPATH`. - Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled. - Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98 ) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
…lve can not enable hadoop short circuit reading in some environments. (apache#21430) Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
… in some environments. (apache#21548) Merge apache#21516 to branch-1.2-lts. Fix hadoop short circuit reading can not enabled in some environments. - Revert apache#21430 because it will cause performance degradation issue. - Add `$HADOOP_CONF_DIR` to `$CLASSPATH`. - Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled. - Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98 ) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
morningman
pushed a commit
that referenced
this pull request
Jul 19, 2023
… in some environments. (#21548) Merge #21516 to branch-1.2-lts. Fix hadoop short circuit reading can not enabled in some environments. - Revert #21430 because it will cause performance degradation issue. - Add `$HADOOP_CONF_DIR` to `$CLASSPATH`. - Remove empty `hdfs-site.xml`. Because in some environments it will cause hadoop short circuit reading can not enabled. - Copy the hadoop common native libs(which is copied from apache/doris-thirdparty#98 ) and add it to `LD_LIBRARY_PATH`. Because in some environments `LD_LIBRARY_PATH` doesn't contain hadoop common native libs, which will cause hadoop short circuit reading can not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/1.2.6-merged
dev/2.0.0-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add hadoop system classpath to CLASSPATH to resolve can not enable hadoop short circuit reading in some environments.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...