[fix](test) fix json test cases by using def keyword to define local variable #21206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuke987
approved these changes
Jun 26, 2023
|
LGTM |
|
PR approved by anyone and no changes requested. |
|
run buildall |
xiaokang
force-pushed
the
fix_json_testcase
branch
from
bbb37c1 to
9160e6e
Compare
|
run buildall |
BiteTheDDDDt
approved these changes
Jul 3, 2023
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
xiaokang
added
dev/2.0.0
xiaokang
added a commit
that referenced
this pull request
Jul 4, 2023
add def keyword to define local variable success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
using
def success = trueinstead ofsuccess = trueto avoid global variable conflict.regression-test/suites/json_p0/test_json_load_and_function.groovy
regression-test/suites/json_p0/test_json_load_unique_key_and_function.groovy
regression-test/suites/jsonb_p0/test_jsonb_load_and_function.groovy
regression-test/suites/jsonb_p0/test_jsonb_load_unique_key_and_function.groovy
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...