[fix](testcase) fix test case failure of insert null value into not null column #20963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
run clickbench |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Aug 25, 2023
…to not null column (apache#20963)" This reverts commit 55a6649. Mannual Revert "[fix](load) in strict mode, return error for insert if datatype convert fails (apache#20378)" This mannual reverts commit 1b94b63
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Aug 25, 2023
…to not null column (apache#20963)" This reverts commit 55a6649. Mannual Revert "[fix](load) in strict mode, return error for insert if datatype convert fails (apache#20378)" This mannual reverts commit 1b94b63
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Aug 25, 2023
…ull value into not null column (apache#20963)" This reverts commit 55a6649. Mannual Revert "[fix](load) in strict mode, return error for insert if datatype convert fails (apache#20378)" This mannual reverts commit 1b94b63
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Aug 25, 2023
…ull value into not null column (apache#20963)" Also Revert "[fix](load) in strict mode, return error for insert if datatype convert fails (apache#20378)"
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Aug 25, 2023
…to not null column (apache#20963)" This reverts commit 55a6649. Mannual Revert "fix in strict mode, return error for insert if datatype convert fails (apache#20378)" This mannual reverts commit 1b94b63
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Aug 25, 2023
…to not null column (apache#20963)" This reverts commit 55a6649. Mannual Revert "fix in strict mode, return error for insert if datatype convert fails (apache#20378)" This mannual reverts commit 1b94b63
yiguolei
pushed a commit
that referenced
this pull request
Aug 25, 2023
…to not null column (#20963)" (#23462) * Revert "[fix](testcase) fix test case failure of insert null value into not null column (#20963)" This reverts commit 55a6649. Mannual Revert "fix in strict mode, return error for insert if datatype convert fails (#20378)" This mannual reverts commit 1b94b63 * fix case failure
jacktengg
added a commit
to jacktengg/incubator-doris
that referenced
this pull request
Aug 25, 2023
…to not null column (apache#20963)" This reverts commit 55a6649. Mannual Revert "fix in strict mode, return error for insert if datatype convert fails (apache#20378)" This mannual reverts commit 1b94b63
yiguolei
pushed a commit
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...