Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](profile) The PID_DIR variable in the Doris stop script does not follow the conf file #20881

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

timyuer
Copy link
Contributor

@timyuer timyuer commented Jun 16, 2023

Proposed changes

Issue: #20784

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@timyuer timyuer changed the title [Bug] The PID_DIR variable in the Doris stop script does not follow the conf file [fix](executor) The PID_DIR variable in the Doris stop script does not follow the conf file Jun 16, 2023
@timyuer timyuer changed the title [fix](executor) The PID_DIR variable in the Doris stop script does not follow the conf file [fix](executor) The PID_DIR variable in the Doris stop script does not follow the conf file (#20784) Jun 16, 2023
@timyuer timyuer changed the title [fix](executor) The PID_DIR variable in the Doris stop script does not follow the conf file (#20784) [fix](executor) The PID_DIR variable in the Doris stop script does not follow the conf file Jun 17, 2023
@timyuer timyuer changed the title [fix](executor) The PID_DIR variable in the Doris stop script does not follow the conf file [fix](config) The PID_DIR variable in the Doris stop script does not follow the conf file Jun 19, 2023
@timyuer timyuer changed the title [fix](config) The PID_DIR variable in the Doris stop script does not follow the conf file [fix](profile) The PID_DIR variable in the Doris stop script does not follow the conf file Jun 19, 2023
@timyuer
Copy link
Contributor Author

timyuer commented Jun 19, 2023

run buildall

@timyuer
Copy link
Contributor Author

timyuer commented Jun 20, 2023

run p0

@timyuer
Copy link
Contributor Author

timyuer commented Jun 20, 2023

@morningman Could you please review it.

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 22, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 37c9a08 into apache:master Jun 22, 2023
@yiguolei yiguolei added dev/2.0.0 2.0.0 release and removed dev/2.0-beta labels Jun 22, 2023
@xiaokang xiaokang added dev/2.0-beta-merged and removed dev/2.0.0 2.0.0 release labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0-beta-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants