[fix](multi-catalog)fix s3 check, complete catalog properties #20591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
morningman
reviewed
Jun 14, 2023
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HiveMetaStoreCache.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/datasource/property/constants/MinioProperties.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/fs/remote/dfs/DFSFileSystem.java
Outdated
Show resolved
Hide resolved
|
I have no more comments, just fix the job conf cache refreshing problem. |
Jibing-Li
approved these changes
Jun 14, 2023
| @@ -153,6 +154,8 @@ public HivePartition load(PartitionCacheKey key) throws Exception { | |||
| * generate a filecache and set to fileCacheRef | |||
| */ | |||
| public void setNewFileCache() { | |||
| // init or refresh job conf | |||
| jobConf = getJobConf(); | |||
There was a problem hiding this comment.
I'm not sure if this change will bring race condition or not. Because the reference of jobConf in getFilesByTransaction and loadFiles may be changed at any time. But I don't think it's a big problem since the refresh frequency is very low.
There was a problem hiding this comment.
add synchronized for getJobConf to avoid this.
|
PR approved by anyone and no changes requested. |
|
run buildall |
1 similar comment
|
run buildall |
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
stability and some fixes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...