Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](docs) fix wrong link #20000

Merged
merged 2 commits into from
May 25, 2023
Merged

[fix](docs) fix wrong link #20000

merged 2 commits into from
May 25, 2023
+2 −2

Conversation

gitccl
Copy link
Contributor

@gitccl gitccl commented May 24, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label May 24, 2023
@nextdreamblue
Copy link
Contributor

20000

@gitccl
Copy link
Contributor Author

gitccl commented May 24, 2023

run buildall

@lexluo09
Copy link
Contributor

20000
take a look

@weizhengte
Copy link
Contributor

+1

3 similar comments
@dutyu
Copy link
Contributor

dutyu commented May 24, 2023

+1

@Yukang-Lian
Copy link
Collaborator

+1

@stalary
Copy link
Contributor

stalary commented May 24, 2023

+1

BiteTheDDDDt
BiteTheDDDDt previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@htyoung
Copy link
Contributor

htyoung commented May 24, 2023

LGTM

stalary
stalary previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@stalary stalary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@wsjz
Copy link
Contributor

wsjz commented May 24, 2023

LGTM

1 similar comment
@lsy3993
Copy link
Contributor

lsy3993 commented May 24, 2023

LGTM

fuchanghai
fuchanghai previously approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liaoxin01
liaoxin01 previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zddr
Copy link
Contributor

zddr commented May 24, 2023

LGTM

qidaye
qidaye previously approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SleepyBear96
Copy link
Contributor

take a look

@zhangyuchi
Copy link

LGTM

@gitccl gitccl dismissed stale reviews from qidaye, liaoxin01, fuchanghai, stalary, and BiteTheDDDDt via 869bf4b May 24, 2023 08:35
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 24, 2023
@whutpencil
Copy link
Contributor

LGTM

zclllyybb
zclllyybb approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zy-kkk
zy-kkk approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@zy-kkk zy-kkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TangSiyang2001
TangSiyang2001 approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@TangSiyang2001 TangSiyang2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caiconghui
caiconghui approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 24, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@luzhijing
Copy link
Contributor

LGTM

Gabriel39
Gabriel39 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adonis0147
adonis0147 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xy720
xy720 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MTGL

LemonLiTree
LemonLiTree approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@LemonLiTree LemonLiTree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catpineapple
Copy link
Contributor

LGTM

2 similar comments
@HonestManXin
Copy link
Contributor

LGTM

@luozenglin
Copy link
Contributor

LGTM

@luzhijing
Copy link
Contributor

run buildall

@luzhijing luzhijing merged commit a3fd7ab into apache:master May 25, 2023
@gitccl gitccl deleted the fix_wronglink branch May 25, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@xy720 xy720 xy720 approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@caiconghui caiconghui caiconghui approved these changes

@adonis0147 adonis0147 adonis0147 approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

@TangSiyang2001 TangSiyang2001 TangSiyang2001 approved these changes

@LemonLiTree LemonLiTree LemonLiTree approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt left review comments

@liaoxin01 liaoxin01 liaoxin01 left review comments

@stalary stalary stalary left review comments

@qidaye qidaye qidaye left review comments

@fuchanghai fuchanghai fuchanghai left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.