Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](third-party) Don't link keyutils to krb5 explicitly #19632

Merged
merged 1 commit into from
May 16, 2023

Conversation

adonis0147
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

We may link system-wide keyutils to krb5 when building krb5 which may introduce an extra dependency to the codebase.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147
Copy link
Contributor Author

adonis0147 commented May 15, 2023

run buildall

@adonis0147
Copy link
Contributor Author

run p0

1 similar comment
@adonis0147
Copy link
Contributor Author

run p0

@morningman morningman self-assigned this May 16, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 16, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 merged commit ddcf7ec into apache:master May 16, 2023
@adonis0147 adonis0147 deleted the dev branch May 16, 2023 02:37
adonis0147 added a commit to adonis0147/doris that referenced this pull request May 16, 2023
…9632)

We may link system-wide keyutils to krb5 when building krb5 which may introduce an extra dependency to the codebase.
adonis0147 added a commit that referenced this pull request May 16, 2023
…19680)

We may link system-wide keyutils to krb5 when building krb5 which may introduce an extra dependency to the codebase.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…9632) (apache#19680)

We may link system-wide keyutils to krb5 when building krb5 which may introduce an extra dependency to the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.5-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants