Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](https) Non leader fe fails to start when enable https #19590

Merged
merged 1 commit into from
May 17, 2023

Conversation

yongjinhou
Copy link
Contributor

Proposed changes

Issue Number: close #19588

Problem summary

Http interfaces between FEs are not redirected.
#19588

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yongjinhou
Copy link
Contributor Author

run buildall

@yongjinhou
Copy link
Contributor Author

run compile

@yiguolei
Copy link
Contributor

run p0

@fsilent
Copy link
Contributor

fsilent commented May 13, 2023

All fe start success and access use https success.
But looks like http login not redirect https correctly.
image
image

@morningman morningman self-assigned this May 15, 2023
@yongjinhou
Copy link
Contributor Author

All fe start success and access use https success. But looks like http login not redirect https correctly. image image

What is the specific problem, I think the redirect code 303 is normal.

@yongjinhou
Copy link
Contributor Author

All fe start success and access use https success. But looks like http login not redirect https correctly. image image

What is the specific problem, I think the redirect code 303 is normal.

a7b32a2809d515648bfea71edbc37e47

@yongjinhou yongjinhou force-pushed the multi_fe_enable_https branch from ae78050 to 44936b3 Compare May 15, 2023 02:45
@yongjinhou
Copy link
Contributor Author

run buildall

@yongjinhou
Copy link
Contributor Author

run p0

@fsilent
Copy link
Contributor

fsilent commented May 15, 2023

Access to fetch at 'https://fe_ip:https_port/rest/v1/login' (redirected from 'http://fe_ip:http_port/rest/v1/login') from origin 'http://fe_ip:http_port' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'.

maybe the curl command does not have cross-domain problems?

@yongjinhou
Copy link
Contributor Author

run p0

1 similar comment
@yongjinhou
Copy link
Contributor Author

run p0

Copy link
Contributor

@pengxiangyu pengxiangyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 17, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@pengxiangyu pengxiangyu merged commit 802e551 into apache:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug](https) Non leader fe fails to start when enable https
5 participants