Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization](statistics) optimize Incremental statistics collection and statistics cleaning #18971

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

weizhengte
Copy link
Contributor

Proposed changes

This pr mainly optimizes the following items:

  • the collection of statistics: clear up invalid historical statistics before collecting them, so as not to affect the final table statistics.
  • the incremental collection of statistics: in the case of incremental collection, only the corresponding partition statistics need to be collected.

TODO: Supports incremental collection of materialized view statistics.

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@weizhengte
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 23, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.6 seconds
stream load tsv: 427 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s
stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230427005408_clickbench_pr_136047.html

@weizhengte weizhengte force-pushed the opt-incre-stats branch 2 times, most recently from cea7318 to 2f1e1f9 Compare April 24, 2023 15:37
@weizhengte weizhengte force-pushed the opt-incre-stats branch 4 times, most recently from 1e8ad51 to 93c73b1 Compare April 25, 2023 16:52
Kikyou1997
Kikyou1997 previously approved these changes Apr 25, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Kikyou1997
Kikyou1997 previously approved these changes Apr 26, 2023
@weizhengte weizhengte force-pushed the opt-incre-stats branch 2 times, most recently from 1fc5a3b to 837cb2f Compare April 26, 2023 14:45
@weizhengte
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 27, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 484612a into apache:master Apr 27, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 27, 2023
…istics cleaning (apache#18971)

This pr mainly optimizes the following items:
- the collection of statistics: clear up invalid historical statistics before collecting them, so as not to affect the final table statistics.
- the incremental collection of statistics: in the case of incremental collection, only the corresponding partition statistics need to be collected.

TODO: Supports incremental collection of materialized view statistics.
@weizhengte weizhengte deleted the opt-incre-stats branch May 10, 2023 03:20
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…istics cleaning (apache#18971)

This pr mainly optimizes the following items:
- the collection of statistics: clear up invalid historical statistics before collecting them, so as not to affect the final table statistics.
- the incremental collection of statistics: in the case of incremental collection, only the corresponding partition statistics need to be collected.

TODO: Supports incremental collection of materialized view statistics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants