Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore](thrift) generate thrift java code to make code analysis work well #18793

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

BiteTheDDDDt
Copy link
Contributor

Proposed changes

generate thrift java code to make code analysis work well
before:
图片
after:
图片

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In build.sh line 394:
rm -rf ${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/doris/thrift ${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/parquet
       ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                                      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
rm -rf "${DORIS_HOME}"/fe/fe-core/src/main/java/org/apache/doris/thrift "${DORIS_HOME}"/fe/fe-core/src/main/java/org/apache/parquet


In build.sh line 395:
cp -r build/gen_java/org/apache/doris/thrift ${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/doris
                                             ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
cp -r build/gen_java/org/apache/doris/thrift "${DORIS_HOME}"/fe/fe-core/src/main/java/org/apache/doris


In build.sh line 396:
cp -r build/gen_java/org/apache/parquet ${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/
                                        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
cp -r build/gen_java/org/apache/parquet "${DORIS_HOME}"/fe/fe-core/src/main/java/org/apache/

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- build.sh.orig
+++ build.sh
@@ -395,7 +395,6 @@
 cp -r build/gen_java/org/apache/doris/thrift ${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/doris
 cp -r build/gen_java/org/apache/parquet ${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/
 
-
 # Assesmble FE modules
 FE_MODULES=''
 BUILD_DOCS='OFF'
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors
'shellcheck ' found no issues.

shfmt errors

'shfmt ' returned error 1 finding the following formatting issues:

----------
--- build.sh.orig
+++ build.sh
@@ -395,7 +395,6 @@
 cp -r "build/gen_java/org/apache/doris/thrift" "${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/doris"
 cp -r "build/gen_java/org/apache/parquet" "${DORIS_HOME}/fe/fe-core/src/main/java/org/apache/"
 
-
 # Assesmble FE modules
 FE_MODULES=''
 BUILD_DOCS='OFF'
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt  -w filename


@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

run feut

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.3 seconds
stream load tsv: 430 seconds loaded 74807831229 Bytes, about 165 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230419031632_clickbench_pr_130803.html

@BiteTheDDDDt
Copy link
Contributor Author

run COMPILE

@BiteTheDDDDt
Copy link
Contributor Author

run p0

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 19, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit c40860a into apache:master Apr 19, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…well (apache#18793)

generate thrift java code to make code analysis work well
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…well (apache#18793)

generate thrift java code to make code analysis work well
@BiteTheDDDDt BiteTheDDDDt deleted the dev_0418 branch January 20, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants