Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE error when creating table with bool column #1864

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

wubiaoi
Copy link
Contributor

@wubiaoi wubiaoi commented Sep 25, 2019

For #1857

@imay
Copy link
Contributor

imay commented Sep 25, 2019

@wubiaoi

For old version storage, we don't support boolean type.
What will happen if you patch is applied when creating boolean type.

@wubiaoi
Copy link
Contributor Author

wubiaoi commented Sep 25, 2019

@imay thanks for the comments.

For old version storage, we don't support boolean type.
What will happen if you patch is applied when creating boolean type.

Now, creating boolean type will thrown NPE instead of a syntax error.
ERROR 1064 (HY000): Unexpected exception: null

After applying this patch, the bool type will be supported similar to mysql.
eg.

create table booltest
(
id boolean null, 
value double sum null
)
engine=olap aggregate key(id) distributed by hash(id) buckets 6 properties("storage_type"="COLUMN","replication_num"="1");
insert into booltest values(false,1.3);
insert into booltest values(false,2.3);
insert into booltest values(true,0.3);
select * from booltest;
id value
1 0.3
0 3.6

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit e43f1a2 into apache:master Sep 25, 2019
@imay imay mentioned this pull request Sep 26, 2019
SWJTU-ZhangLei pushed a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants