Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](third-party) Configure the search paths for pkg-config and cmake #18624

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Apr 13, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Currently, our third party libraries are built by autotools or cmake. Under some scenarios, we may use system-wide headers or libraries to build them which may make the build process fail.

We can configure the search paths explicitly to help autotools and cmake find the right dependencies.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@adonis0147 adonis0147 changed the title [chore](third-party) Configure search path for pkg-config and cmake [chore](third-party) Configure the search paths for pkg-config and cmake Apr 13, 2023
@adonis0147
Copy link
Contributor Author

run buildall

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 13, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 merged commit d28030e into apache:master Apr 14, 2023
@adonis0147 adonis0147 deleted the third-party branch April 14, 2023 00:43
adonis0147 added a commit to adonis0147/doris that referenced this pull request Apr 14, 2023
…ake (apache#18624)

Currently, our third party libraries are built by autotools or cmake. Under some scenarios, we may use system-wide headers or libraries to build them which may make the build process fail.

We can configure the search paths explicitly to help autotools and cmake find the right dependencies.
adonis0147 added a commit that referenced this pull request Apr 14, 2023
…ake (#18624) (#18661)

Currently, our third party libraries are built by autotools or cmake. Under some scenarios, we may use system-wide headers or libraries to build them which may make the build process fail.

We can configure the search paths explicitly to help autotools and cmake find the right dependencies.
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…ake (apache#18624)

Currently, our third party libraries are built by autotools or cmake. Under some scenarios, we may use system-wide headers or libraries to build them which may make the build process fail.

We can configure the search paths explicitly to help autotools and cmake find the right dependencies.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
…ake (apache#18624)

Currently, our third party libraries are built by autotools or cmake. Under some scenarios, we may use system-wide headers or libraries to build them which may make the build process fail.

We can configure the search paths explicitly to help autotools and cmake find the right dependencies.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
…ake (apache#18624) (apache#18661)

Currently, our third party libraries are built by autotools or cmake. Under some scenarios, we may use system-wide headers or libraries to build them which may make the build process fail.

We can configure the search paths explicitly to help autotools and cmake find the right dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants