[Pipeline](exec) Support shared scan in colo agg #18457
Conversation
github-actions
bot
added
area/planner
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| bool has_enough_space_in_blocks_queue() const override { | ||
| return _current_used_bytes < _max_bytes_in_queue / 2 * _max_queue_size; | ||
| } | ||
|
|
||
| virtual void _dispose_coloate_blocks_not_in_queue() override { |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [modernize-use-override]
| virtual void _dispose_coloate_blocks_not_in_queue() override { | |
| void _dispose_coloate_blocks_not_in_queue() override { |
|
run buildall |
|
run buildall |
|
TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
HappenLee
force-pushed
the
bug
branch
2 times, most recently
from
973205e to
0432f0c
Compare
|
run buildall |
1 similar comment
|
run buildall |
| auto* __restrict hashes = hash_vals.data(); | ||
|
|
||
| for (int j = 0; j < _col_distribute_ids.size(); ++j) { | ||
| DCHECK_GT(block->columns(), _col_distribute_ids[j]) << "happen lee:" << print_id(_state->query_id()); |
There was a problem hiding this comment.
warning: member access into incomplete type 'doris::RuntimeState' [clang-diagnostic-error]
DCHECK_GT(block->columns(), _col_distribute_ids[j]) << "happen lee:" << print_id(_state->query_id());
^be/src/udf/udf.h:41: forward declaration of 'doris::RuntimeState'
class RuntimeState;
^| for (int j = 0; j < _col_distribute_ids.size(); ++j) { | ||
| DCHECK_GT(block->columns(), _col_distribute_ids[j]) << "happen lee:" << print_id(_state->query_id()); | ||
| DCHECK_NE(block->get_by_position(_col_distribute_ids[j]) | ||
| .column.get(), nullptr) << "happen lee:" << print_id(_state->query_id()); |
There was a problem hiding this comment.
warning: member access into incomplete type 'doris::RuntimeState' [clang-diagnostic-error]
.column.get(), nullptr) << "happen lee:" << print_id(_state->query_id());
^be/src/udf/udf.h:41: forward declaration of 'doris::RuntimeState'
class RuntimeState;
^
|
run p0 |
|
run p0 |
|
run buildall |
|
run buildall |
Proposed changes
Before do the opt ckbench：
21.8s
After do the opt ckbench：
18.9s
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...