Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](inverted index) fix inverted index to support NULL value filter #18302

Merged
merged 9 commits into from
Apr 15, 2023

Conversation

xiaokang
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

xiaokang commented Apr 2, 2023

run buildall

1 similar comment
@xiaokang
Copy link
Contributor Author

xiaokang commented Apr 3, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

xiaokang commented Apr 3, 2023

run p0

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

run buildall

1 similar comment
@xiaokang
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

// test match predicates
qt_select_match_1 "SELECT * FROM ${table1} WHERE addr MATCH_ANY 'addr fengtai' ORDER BY id"
qt_select_match_2 "SELECT * FROM ${table1} WHERE addr MATCH_ALL 'addr fengtai' ORDER BY id"
}
Copy link
Contributor

@Tanya-W Tanya-W Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there also can add some is_null or is_not_null predicates case, but need change the function SegmentIterator::_inverted_index_not_support_pred_type in segment_iterator.cpp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@xiaokang xiaokang force-pushed the inverted_index_support_null branch from 8a53342 to bbfa070 Compare April 11, 2023 16:06
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Tanya-W
Tanya-W previously approved these changes Apr 13, 2023
Copy link
Contributor

@Tanya-W Tanya-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

run buildall

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit 98b8bef into apache:master Apr 15, 2023
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Apr 15, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants