[fix](chore) fix BE compile and FE protoc artifact issue #18120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
add <optional> head to solve the compilation issue use 3.12.9 as the protoc.artifact's version, because there is no 3.12.21 See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/ Remove --show-progress arguments of wget because it is not supported in low version wget
adonis0147
pushed a commit
to adonis0147/doris
that referenced
this pull request
May 11, 2023
add <optional> head to solve the compilation issue use 3.12.9 as the protoc.artifact's version, because there is no 3.12.21 See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/ Remove --show-progress arguments of wget because it is not supported in low version wget
5 tasks
adonis0147
added a commit
that referenced
this pull request
May 11, 2023
…9522) 1. add <optional> head to solve the compilation issue use 3.12.9 as the protoc.artifact's version, because there is no 3.12.21 See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/ 2. Remove --show-progress arguments of wget because it is not supported in low version wget 3. Downgrade grpc.version to 1.30.0 (See #8250). Co-authored-by: Mingyu Chen <morningman@163.com>
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Jul 12, 2023
… (apache#19522) 1. add <optional> head to solve the compilation issue use 3.12.9 as the protoc.artifact's version, because there is no 3.12.21 See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/ 2. Remove --show-progress arguments of wget because it is not supported in low version wget 3. Downgrade grpc.version to 1.30.0 (See apache#8250). Co-authored-by: Mingyu Chen <morningman@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
<optional>head to solve the compilation issue3.12.9as the protoc.artifact's version, because there is no 3.12.21See: https://repo.maven.apache.org/maven2/com/google/protobuf/protoc/
--show-progressarguments ofwgetbecause it is not supported in low versionwgetChecklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...