Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vectorized](function) Support array_shuffle and shuffle function. #18116

Merged
merged 9 commits into from
Apr 4, 2023

Conversation

ZhangYu0123
Copy link
Contributor

Proposed changes

Support array_shuffle and shuffle function.

image

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. kind/test labels Mar 26, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZhangYu0123
Copy link
Contributor Author

run buildall

@ZhangYu0123 ZhangYu0123 force-pushed the support_array_shuffle branch from c786c52 to 2fafa23 Compare March 31, 2023 13:06
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ZhangYu0123
Copy link
Contributor Author

run p0

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

PR approved by anyone and no changes requested.

Copy link
Collaborator

@Yukang-Lian Yukang-Lian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 8b85c55 into apache:master Apr 4, 2023
Mryange pushed a commit to Mryange/doris that referenced this pull request Apr 4, 2023
…pache#18116)


---------

Co-authored-by: zhangyu209 <zhangyu209@meituan.com>
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…pache#18116)


---------

Co-authored-by: zhangyu209 <zhangyu209@meituan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants