Skip to content

[fix](agg) Avoid reusing a non-nullable column that has been converted to nullable within a block #17944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Mar 21, 2023
Merged

[fix](agg) Avoid reusing a non-nullable column that has been converted to nullable within a block #17944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions be/src/vec/exec/vaggregation_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,8 +1030,10 @@ Status AggregationNode::_pre_agg_with_serialized_key(doris::vectorized::Block* i
SCOPED_TIMER(_streaming_agg_timer);
ret_flag = true;

// will serialize value data to string column
bool mem_reuse = out_block->mem_reuse();
// will serialize value data to string column.
// non-nullable column(id in `_make_nullable_keys`)
// will be converted to nullable.
bool mem_reuse = _make_nullable_keys.empty() && out_block->mem_reuse();

std::vector<DataTypePtr> data_types;
MutableColumns value_columns;
Expand Down Expand Up @@ -1136,7 +1138,8 @@ Status AggregationNode::_execute_with_serialized_key(Block* block) {

Status AggregationNode::_get_with_serialized_key_result(RuntimeState* state, Block* block,
bool* eos) {
bool mem_reuse = block->mem_reuse();
// non-nullable column(id in `_make_nullable_keys`) will be converted to nullable.
bool mem_reuse = _make_nullable_keys.empty() && block->mem_reuse();
auto column_withschema = VectorizedUtils::create_columns_with_type_and_name(_row_descriptor);
int key_size = _probe_expr_ctxs.size();

Expand Down Expand Up @@ -1241,7 +1244,8 @@ Status AggregationNode::_serialize_with_serialized_key_result(RuntimeState* stat
MutableColumns value_columns(agg_size);
DataTypes value_data_types(agg_size);

bool mem_reuse = block->mem_reuse();
// non-nullable column(id in `_make_nullable_keys`) will be converted to nullable.
bool mem_reuse = _make_nullable_keys.empty() && block->mem_reuse();

MutableColumns key_columns;
for (int i = 0; i < key_size; ++i) {
Expand Down