[Chore](build) fix some warning on code generate and webui #17078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
BiteTheDDDDt
changed the title
|
run buildall |
|
run p0 |
|
run feut |
| @@ -598,7 +598,6 @@ import org.apache.doris.qe.SqlModeHelper; | |||
| %init} | |||
|
|
|||
| LineTerminator = \r|\n|\r\n | |||
| NonTerminator = [^\r\n] | |||
There was a problem hiding this comment.
The code does not belong to the PR’s title
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ |
There was a problem hiding this comment.
The code does not belong to the PR’s title
BiteTheDDDDt
changed the title
|
PR approved by anyone and no changes requested. |
Yulei-Yang
pushed a commit
to Yulei-Yang/doris
that referenced
this pull request
Mar 5, 2023
[WARNING:gensrc/thrift/parquet.thrift:22] Uncaptured doctext at on line 18. [WARNING:gensrc/thrift/parquet.thrift:23] Uncaptured doctext at on line 22. [WARNING:gensrc/thrift/parquet.thrift:436] Uncaptured doctext at on line 428. WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit Warning : Macro "NonTerminator" has been declared but never used.
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
[WARNING:gensrc/thrift/parquet.thrift:22] Uncaptured doctext at on line 18. [WARNING:gensrc/thrift/parquet.thrift:23] Uncaptured doctext at on line 22. [WARNING:gensrc/thrift/parquet.thrift:436] Uncaptured doctext at on line 428. WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web performance WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit Warning : Macro "NonTerminator" has been declared but never used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...