[Fix](inverted index) fix array inverted index error match result when doing schema change add index #16839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n doing schema change add index
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
…n doing schema change add index (apache#16839) There is a bug in inverted_index_writer when adding multiple lines array values' index. This problem can cause error result when doing schema change adding index.
SWJTU-ZhangLei
pushed a commit
to SWJTU-ZhangLei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…o fix inverted index issues (apache#1425) * [Fix](inverted index) fix add nulls bug for inverted fulltext index (apache#16078) We found a problem with inverted index when parser=english, if there were nulls in columns when flushing inverted index for them, it can cause CLucene throwing an exception. * [fix](regression test) fix test_array_index.groovy without 'order by' lead to result mismatch (apache#16575) * [fix](inverted index) fix array type inverted index query error (apache#16582) * [Fix](inverted index) fix array inverted index error match result when doing schema change add index (apache#16839) There is a bug in inverted_index_writer when adding multiple lines array values' index. This problem can cause error result when doing schema change adding index. ----------- commit 1a9eefe Author: airborne12 <[airborne08@gmail.com](mailto:airborne08@gmail.com)> Date: Fri Feb 17 11:50:39 2023 +0800 [Fix](inverted index) fix array inverted index error match result when doing schema change add index (apache#16839) commit ad14174 Author: YueW <[45946325+Tanya-W@users.noreply.github.com](mailto:45946325+Tanya-W@users.noreply.github.com)> Date: Fri Feb 10 17:57:15 2023 +0800 [fix](inverted index) fix array type inverted index query error (apache#16582) commit e682991 Author: YueW <[45946325+Tanya-W@users.noreply.github.com](mailto:45946325+Tanya-W@users.noreply.github.com)> Date: Fri Feb 10 08:53:22 2023 +0800 [fix](regression test) fix test_array_index.groovy without 'order by' lead to result mismatch (apache#16575) commit 69a3ecf Author: airborne12 <[airborne08@gmail.com](mailto:airborne08@gmail.com)> Date: Thu Jan 19 21:21:44 2023 +0800 [Fix](inverted index) fix add nulls bug for inverted fulltext index (apache#16078) --------- Co-authored-by: airborne12 <airborne08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #16838
Problem summary
There is a bug in inverted_index_writer when adding multiple lines array values' index.
This problem can cause error result when doing schema change adding index.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...