Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug](udf) fix udf return type of decimal check scale must is 9 #16497

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

ERROR 1105 (HY000): errCode = 2, detailMessage = [INTERNAL_ERROR]UdfRuntimeException: UDF::evaluate() ran into a problem. CAUSED BY: IllegalArgumentException: Scale of DECIMALV2 must be 9
Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@carlvinhust2012
Copy link
Contributor

What is the effect of this change? Not report error?

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 8, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.3 seconds
stream load tsv: 463 seconds loaded 74807831229 Bytes, about 154 MB/s
stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s
stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230210162142_clickbench_pr_93954.html

@zhangstar333
Copy link
Contributor Author

What is the effect of this change? Not report error?

remove the check, and set scale to 9 always

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some regression test for this?

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants