Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](profile) fix /rest/v1/query_profile action. #15981

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

dutyu
Copy link
Contributor

@dutyu dutyu commented Jan 16, 2023

Proposed changes

PR15898 add jobId column, so /rest/v1/query_profile action should modify the href field.
The result is as follows:
image

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Jan 16, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.97 seconds
load time: 498 seconds
storage size: 17123502870 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230117094017_clickbench_pr_81990.html

@dutyu dutyu force-pushed the fix-query-profile-action branch from db99664 to aaddc74 Compare January 17, 2023 01:59
@dutyu dutyu force-pushed the fix-query-profile-action branch from aaddc74 to 4bbd59c Compare January 17, 2023 06:19
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 061b28b into apache:master Jan 17, 2023
dutyu added a commit to dutyu/doris that referenced this pull request Feb 1, 2023
Co-authored-by: wangxiangyu@360shuke.com <wangxiangyu@360shuke.com>
@dutyu dutyu deleted the fix-query-profile-action branch February 9, 2023 01:52
morningman pushed a commit that referenced this pull request Feb 19, 2023
Co-authored-by: wangxiangyu@360shuke.com <wangxiangyu@360shuke.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants