Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compile](lzo) fix lzo decompressor compiler error #15956

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

HappenLee
Copy link
Contributor

Proposed changes

Fixed it:

In file included from /mnt/disk1/baizhenbo/mycode/incubator-doris/be/src/exec/plain_text_line_reader.cpp:21:
/mnt/disk1/baizhenbo/mycode/incubator-doris/be/src/exec/decompressor.h:153:64: error: missing field 'lib_version' initializer [-Werror,-Wmissing-field-initializers]
: Decompressor(CompressType::LZOP), _header_info({0}), _is_header_loaded(false) {}

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 16, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.03 seconds
load time: 497 seconds
storage size: 17122649158 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230116070045_clickbench_pr_80887.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants