Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](bitmap) fix bitmap iterator comparison error #15779

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

luozenglin
Copy link
Contributor

@luozenglin luozenglin commented Jan 10, 2023

Proposed changes

Issue Number: close #15797

Problem summary

The problem is caused by the fact that bitmap.begin() == bitmap.end() is always true when the bitmap contains a single value.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.15 seconds
load time: 518 seconds
storage size: 17122265584 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230110154814_clickbench_pr_77013.html

@morningman
Copy link
Contributor

please link to an issue

@luozenglin
Copy link
Contributor Author

please link to an issue

done

Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 12, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xy720 xy720 merged commit b1fb127 into apache:master Jan 13, 2023
morningman pushed a commit that referenced this pull request Jan 13, 2023
Fix the bug that bitmap.begin() == bitmap.end() is always true when the bitmap contains a single value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.2-merged kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] inbitmap query result is incorrect
5 participants