[feature](multi-catalog) support postgresql jdbc catalog #15570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/docs
|
TeamCity pipeline, clickbench performance test result: |
morningman
reviewed
Jan 3, 2023
| @@ -371,11 +395,10 @@ public Type mysqlTypeToDoris(JdbcFieldSchema fieldSchema) { | |||
| case "BIGINT": | |||
| return Type.BIGINT; | |||
| case "DATE": | |||
| return ScalarType.getDefaultDateType(Type.DATE); | |||
| return Type.DATE; | |||
There was a problem hiding this comment.
Why not still using ScalarType.getDefaultDateType, so that we can control the behavior by FE config?
There was a problem hiding this comment.
Because jdbc external table do not support convert other database type to DATEV2/TIMESTAMPV2 type of doris
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java
Outdated
Show resolved
Hide resolved
morningman
reviewed
Jan 4, 2023
docs/en/docs/sql-manual/sql-reference/Data-Definition-Statements/Create/CREATE-CATALOG.md
Outdated
Show resolved
Hide resolved
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
pushed a commit
that referenced
this pull request
Jan 8, 2023
support postgresql jdbc catalog
luwei16
pushed a commit
to luwei16/incubator-doris
that referenced
this pull request
Apr 7, 2023
support postgresql jdbc catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #14527
support postgresql jdbc catalog
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...