Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement](thirdparty)upgrade simdjson from 1.0.2 to 3.0.1 #15412

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

xiaokang
Copy link
Contributor

@xiaokang xiaokang commented Dec 27, 2022

Proposed changes

Upgrade simdjson from 1.0.2 to latest version 3.0.1 to avoid -mlzcnt compiler flag causing BE UT(macOS) failure.

simdjson is now only used by VJsonScanner and disabled by default. So the impact of upgrade is limited.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 27, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.19 seconds
load time: 634 seconds
storage size: 17123661633 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221228021356_clickbench_pr_69737.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit fe02b08 into apache:master Dec 28, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 28, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

morningman pushed a commit that referenced this pull request Dec 28, 2022
Upgrade simdjson from 1.0.2 to latest version 3.0.1 to avoid -mlzcnt compiler flag causing BE UT(macOS) failure.
simdjson is now only used by VJsonScanner and disabled by default. So the impact of upgrade is limited.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.1-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants