Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature](Nereids): generate phyiscal plan in DPhyp #15264

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

keanji-x
Copy link
Contributor

@keanji-x keanji-x commented Dec 22, 2022

Signed-off-by: xiejiann jianxie0@gmail.com

Proposed changes

Issue Number: close #xxx

generate distributed plan in DPhyp

Problem summary

we need to generate physical plans and consider distributed plans for a more accurate cost.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@keanji-x keanji-x marked this pull request as draft December 22, 2022 02:50
@keanji-x keanji-x force-pushed the physical-DPhyp branch 2 times, most recently from a215465 to 87baff5 Compare December 26, 2022 08:32
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 26, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.5 seconds
load time: 484 seconds
storage size: 17122980373 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230129172038_clickbench_pr_86653.html

@keanji-x keanji-x force-pushed the physical-DPhyp branch 5 times, most recently from 958a438 to 7cce77d Compare December 27, 2022 03:14
@keanji-x keanji-x marked this pull request as ready for review December 27, 2022 03:15
@keanji-x keanji-x force-pushed the physical-DPhyp branch 9 times, most recently from f20d1fa to 2b43c5e Compare December 30, 2022 12:27
Signed-off-by: xiejiann <jianxie0@gmail.com>
@keanji-x keanji-x force-pushed the physical-DPhyp branch 4 times, most recently from a5fc16b to 846aaed Compare January 29, 2023 13:54
Copy link
Member

@jackwener jackwener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


// For other projects, such as project constant or project nullable, we construct a new project above root
if (otherProject.size() != 0) {
otherProject.addAll(memoRoot.getLogicalExpression().getPlan().getOutput());
otherProject.addAll(optimized.getLogicalExpression().getPlan().getOutput());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next PR, we can rename optimized -> optimizedGroup

@jackwener jackwener merged commit e7cd85f into apache:master Jan 31, 2023
englefly pushed a commit to englefly/incubator-doris that referenced this pull request Feb 1, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 1, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants