-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](Nereids): generate phyiscal plan in DPhyp #15264
Conversation
a215465
to
87baff5
Compare
TeamCity pipeline, clickbench performance test result: |
958a438
to
7cce77d
Compare
f20d1fa
to
2b43c5e
Compare
2b43c5e
to
d20a00e
Compare
Signed-off-by: xiejiann <jianxie0@gmail.com>
a5fc16b
to
846aaed
Compare
846aaed
to
4ca463a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
// For other projects, such as project constant or project nullable, we construct a new project above root | ||
if (otherProject.size() != 0) { | ||
otherProject.addAll(memoRoot.getLogicalExpression().getPlan().getOutput()); | ||
otherProject.addAll(optimized.getLogicalExpression().getPlan().getOutput()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next PR, we can rename optimized
-> optimizedGroup
Signed-off-by: xiejiann jianxie0@gmail.com
Proposed changes
Issue Number: close #xxx
generate distributed plan in DPhyp
Problem summary
we need to generate physical plans and consider distributed plans for a more accurate cost.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...