Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](InBitmap) Check whether the in bitmap contains correlated subqueries #15184

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

luozenglin
Copy link
Contributor

  1. Currently in bitmap does not support correlated subquery, like: a.k1 in (select bitmap_col from b where a.k2 = b.k2).

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…eries

1. Currently in bitmap does not support correlated subquery, like:
  `a.k1 in (select bitmap_col from b where a.k2 = b.k2)`.
@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Dec 19, 2022
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 19, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.57 seconds
load time: 632 seconds
storage size: 17123019789 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221219151930_clickbench_pr_65256.html

Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 20, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/1.2.1-merged kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants