Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vectorized](jdbc) fix external table of oracle with condition about … #15092

Merged
merged 2 commits into from
Dec 16, 2022
Merged

[vectorized](jdbc) fix external table of oracle with condition about … #15092

merged 2 commits into from
Dec 16, 2022

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Dec 15, 2022 •
edited
Loading

issue: #15069 #15086

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/vectorization labels Dec 15, 2022
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.09 seconds
load time: 446 seconds
storage size: 17123356915 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221215041007_clickbench_pr_63635.html

HappenLee
HappenLee approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 15, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 728a238 into apache:master Dec 16, 2022
morningman pushed a commit that referenced this pull request Dec 19, 2022
@zhangstar333 @morningman
[vectorized](jdbc) fix external table of oracle with condition about … (
cc13983 
#15092)

* [vectorized](jdbc) fix external table of oracle with condition about datetime report error

* formatter
@zhangstar333 zhangstar333 mentioned this pull request Dec 20, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner area/vectorization dev/1.2.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangstar333 @hello-stephen @HappenLee @morningman @yiguolei