Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](multi-catalog)Regression test for external hive orc table #13762

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

AshinGau
Copy link
Member

@AshinGau AshinGau commented Oct 28, 2022

Proposed changes

Add regression test for external hive orc table. This PR has generated all basic types support by hive orc, and create a hive external table to touch them in docker environment.
Functions to be tested:

  1. Ensure that all types are parsed correctly
  2. Ensure that the null map of all types are parsed correctly
  3. Ensure that the SearchArgument of OrcReader works well
  4. Only select partition columns

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2022

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.69 seconds
load time: 443 seconds
storage size: 17171955553 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221117091532_clickbench_pr_47826.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 44ee438 into apache:master Nov 17, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Nov 27, 2022
…che#13762)

Add regression test for external hive orc table. This PR has generated all basic types support by hive orc, and create a hive external table to touch them in docker environment.
Functions to be tested:
1. Ensure that all types are parsed correctly
2. Ensure that the null map of all types are parsed correctly
3. Ensure that the `SearchArgument` of `OrcReader` works well
4. Only select partition columns
@AshinGau AshinGau deleted the orc-partition branch December 20, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants