Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](build) Pass the compile flag -Wno-unused-but-set-variable on demand #13716

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Oct 27, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

There are some issues with the compile flag -Wno-unused-but-set-variable for clang.

  1. -Wno-unused-but-set-variable should be set when building source by clang-15 on Linux. ([chore](build) Fix compilation errors reported by clang-15 #13000 [chore](third-party) Fix compilation errors reported by clang-15 #13016)
  2. On macOS Monterey, Apple Clang 13 may treat it as a unknown warning option and the compilation process may interrupt.

This PR introduces a better way to make this compile flag more portable.

  1. Test whether the compiler recognizes this flag.
  2. Add this flag if the compiler recognizes it.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.42 seconds
load time: 570 seconds
storage size: 17154644056 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027125013_clickbench_pr_34589.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 27, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@adonis0147 adonis0147 merged commit bad9501 into apache:master Oct 27, 2022
@adonis0147 adonis0147 deleted the build branch October 27, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants