Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](join)output all value from no-null side of outer join #13655

Merged
merged 2 commits into from
Oct 27, 2022
Merged

[fix](join)output all value from no-null side of outer join #13655

merged 2 commits into from
Oct 27, 2022

Conversation

starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 25, 2022 •
edited
Loading

Proposed changes

Issue Number: close #xxx

Problem summary

  1. move _convert_block_to_null right after _do_evaluate function
  2. output all values from no-null side of outer join

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@starocean999 starocean999 changed the title [fix](joinoutput all value from no-null side of outer join [fix](join)output all value from no-null side of outer join Oct 25, 2022
@morningman
Copy link
Contributor

Please add some test case

@starocean999 starocean999 force-pushed the master_lc_fix branch 2 times, most recently from 180a9ea to e7dc581 Compare October 26, 2022 09:37
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.14 seconds
load time: 593 seconds
storage size: 17154821058 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026105546_clickbench_pr_34298.html

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.52 seconds
load time: 569 seconds
storage size: 17154644789 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026215017_clickbench_pr_34401.html

@yiguolei yiguolei added dev/1.1.4-deprecated usercase Important user case type label labels Oct 27, 2022
HappenLee
HappenLee approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 27, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit c874931 into apache:master Oct 27, 2022
@wangbo wangbo mentioned this pull request Nov 2, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/vectorization dev/1.1.5 kind/test reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@starocean999 @morningman @hello-stephen @HappenLee @yiguolei