Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](arrayjoin) inner join return wrong result #13608

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Oct 24, 2022

Proposed changes

Issue Number: close #13606

Problem summary

In vectorized engine, columns in block should have the same rows.

Inside functions probe_side_output_column and build_side_output_column, for non-output columns,
if we need output the column, we use insert_from or insert_indices_from to append some data,
for columns we do not need output, we also need to append some default data.

To make sure columns size are the same for all columns inside the same block.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg merged commit 738da0b into apache:master Oct 27, 2022
@yiguolei yiguolei changed the title [bugfix](join) inner join return wrong result [bugfix](arrayjoin) inner join return wrong result Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] inner join with functions return wrong result
2 participants