Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix](load) fix be may core dump when load column mapping has function #12509

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented Sep 9, 2022

Proposed changes

Issue Number: close #12507

Problem summary

fix be may core dump when load column mapping has function
this bug may be introduced by #12375

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: Actually, this bug is caused by processing nullable info incorrectly on row-based engine. And we don't decide to fix this on this engine obsoleted soon so just skip the logics here.

@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load approved Indicates a PR has been approved by one committer. labels Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/load Issues or PRs related to all kinds of load reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] be may core dump when load column mapping has function
3 participants