Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](simdjson) disable simdjson by default, wait for fix the bug #12179

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented Aug 30, 2022

Proposed changes

disable simdjson by default, wait for fix the bug

Problem summary

disable simdjson by default, wait for fix the bug

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

yiguolei
yiguolei previously approved these changes Aug 30, 2022
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

morningman
morningman previously approved these changes Aug 30, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 30, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon previously approved these changes Aug 30, 2022
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg dismissed stale reviews from eldenmoon, morningman, and yiguolei via 03d43f2 August 30, 2022 08:13
@yangzhg yangzhg force-pushed the fix_simdjson branch 2 times, most recently from 03d43f2 to 500849b Compare August 30, 2022 08:16
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caiconghui caiconghui merged commit fdd236c into apache:master Aug 30, 2022
xinyiZzz pushed a commit to xinyiZzz/incubator-doris that referenced this pull request Aug 30, 2022
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 31, 2022
Yukang-Lian pushed a commit to Yukang-Lian/doris that referenced this pull request Sep 2, 2022
Yukang-Lian pushed a commit to Yukang-Lian/doris that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/vectorization reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants