Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug](shell) fix wrong condition expression in script #11913

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39
Copy link
Contributor Author

cc @adonis0147 this condition always return false now

@adonis0147
Copy link
Contributor

Would you like to provide some steps to reproduce the issue? I ran bash -x run-regression-test.sh on my machine but found the condition passed.

@adonis0147
Copy link
Contributor

adonis0147 commented Aug 19, 2022

Finally, I got the issue which the pr aims at resolving.

When we run run-regression-test.sh, the script always builds the jar for regression test framework even if the jar was built before.

@Gabriel39 Gabriel39 requested a review from adonis0147 August 19, 2022 07:37
Gabriel39 and others added 2 commits August 19, 2022 15:41
Copy link
Contributor

@adonis0147 adonis0147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit c82d768 into apache:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants