Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](core)fix bug for status not init #11730

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

pengxiangyu
Copy link
Contributor

@pengxiangyu pengxiangyu commented Aug 12, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

Fix bug for status not init. It may cause build --be failed.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@@ -45,7 +45,7 @@ Status VIntersectNode::open(RuntimeState* state) {
START_AND_SCOPE_SPAN(state->get_tracer(), span, "VIntersectNode::open");
RETURN_IF_ERROR(VSetOperationNode::open(state));
bool eos = false;
Status st;
Status st = Status::OK();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not. Add a default constructor and set st to ok?

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 1c4927e into apache:master Aug 12, 2022
morningman pushed a commit that referenced this pull request Aug 15, 2022
@pengxiangyu pengxiangyu deleted the fix_bug branch September 1, 2022 03:17
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants