[Fix](stream-load-json) fix VJsonReader::_write_data_to_column invali… #11564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xy720
reviewed
Aug 8, 2022
|
@xy720 I will add a regression-test for this fix |
…d column type cast when meet null column_ptr will be a none nullable column pointer after `column_ptr = &nullable_column->get_nested_column()` so we should not cast column_ptr to ColumnNullable any more
eldenmoon
force-pushed
the
fix-_write_data_to_column_null
branch
from
abc70dc to
51a8fba
Compare
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d column type cast when meet null
column_ptr will be a none nullable column pointer after
column_ptr = &nullable_column->get_nested_column()so we should not cast column_ptr to ColumnNullable any more
Proposed changes
Issue Number: close #11567
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...