-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature-wip](multi-catalog)(fix) federation query failed #10602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Jul 5, 2022
0dd8b8d
to
9b8db72
Compare
morningman
previously approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
morningman
previously approved these changes
Jul 6, 2022
PR approved by at least one committer and no changes requested. |
morningman
approved these changes
Jul 8, 2022
PR approved by at least one committer and no changes requested. |
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
Fix apache#10521, multi-catalog query failed for two reasons: 1. The `SelectStmt` does not get the correct catalog. 2. External table should have three level aliases. Disable querying external views. Support show create table for external table&view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
area/multi-catalog
area/nereids
area/planner
Issues or PRs related to the query planner
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem Summary:
Fix #10521, multi-catalog query failed for two reasons:
SelectStmt
does not get the correct catalog.Disable querying external views.
Support show create table for external table&view.
Usage
Without ambiguity, four formats of
select columns
and three formats offrom tables
are supported.select columns
from tables
q3 in tpch
take q3 in tpch as an example:
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...