Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](optimizer) Fix the default join reorder algorithm #10174

Merged
merged 4 commits into from
Jun 17, 2022
Merged

[fix](optimizer) Fix the default join reorder algorithm #10174

merged 4 commits into from
Jun 17, 2022

Conversation

Kikyou1997
Copy link
Contributor

Proposed changes

Issue Number: #10167

Problem Summary:

Default join reorder algorithm not working for the most cases.

Checklist(Required)

  1. Does it affect the original behavior: (Yes)
  2. Has unit tests been added: (Yes)
  3. Has document been added or modified: (No Need)
  4. Does it need to update dependencies: (No)
  5. Are there any changes that cannot be rolled back: (No)

morrySnow
morrySnow previously approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jun 16, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman added the dev/1.0.1-deprecated should be merged into dev-1.0.1 branch label Jun 16, 2022
@morningman morningman added this to the v1.1 milestone Jun 16, 2022
@EmmyMiao87 EmmyMiao87 added the kind/fix Categorizes issue or PR as related to a bug. label Jun 16, 2022
morningman
morningman reviewed Jun 16, 2022
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java Outdated
Expr.getIds(Lists.newArrayList(candidateEqJoinPredicate), candidateTupleList, null);
int count = candidateTupleList.size();
for (TupleId tupleId : candidateTupleList) {
if (validTupleId.contains(tupleId) || tid == tupleId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use == to compare the TupleId?

morningman
morningman approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 16, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@morningman morningman merged commit 67e9527 into apache:master Jun 17, 2022
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Jun 17, 2022
morningman pushed a commit that referenced this pull request Jun 17, 2022
@Kikyou1997 @morningman
[fix](optimizer) Fix the default join reorder algorithm (#10174)
a9e7a1e 
Default join reorder algorithm not working for the most cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@morrySnow morrySnow morrySnow left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/fix Categorizes issue or PR as related to a bug. reviewed
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Kikyou1997 @morningman @morrySnow @EmmyMiao87