Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style](fe)the last step of fe CheckStyle #10134

Merged
merged 10 commits into from
Jun 17, 2022
Merged

[style](fe)the last step of fe CheckStyle #10134

merged 10 commits into from
Jun 17, 2022

Conversation

morrySnow
Copy link
Contributor

  1. fix all CheckStyle warning
  2. change all CheckStyle rules to error
  3. remove some java doc rules
    a. RequireEmptyLineBeforeBlockTagGroup
    b. JavadocStyle
    c. JavadocParagraph
  4. suppress some rules for old codes
    a. all java doc rules only affect on Nereids
    b. DeclarationOrder only affect on Nereids
    c. OverloadMethodsDeclarationOrder only affect on Nereids
    d. VariableDeclarationUsageDistance only affect on Nereids
    e. suppress OneTopLevelClass on org/apache/doris/load/loadv2/dpp/ColumnParser.java
    f. suppress OneTopLevelClass on org/apache/doris/load/loadv2/dpp/SparkRDDAggregator.java
    g. suppress LineLength on org/apache/doris/catalog/FunctionSet.java
    h. suppress LineLength on org/apache/doris/common/ErrorCode.java

Proposed changes

Issue Number: close #9406

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: No Need
  3. Has document been added or modified: No
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

@morrySnow
[style](fe)the last step of fe checkstyle
def3e64 
1. fix all checkstyle warning
2. change all checkstyle rules to error
3. remove some java doc rules
    a. RequireEmptyLineBeforeBlockTagGroup
    b. JavadocStyle
    c. JavadocParagraph
4. suppress some rules for old codes
    a. all java doc rules only affect on Nereids
    b. DeclarationOrder only affect on Nereids
    c. OverloadMethodsDeclarationOrder only affect on Nereids
    d. VariableDeclarationUsageDistance only affect on Nereids
    e. suppress OneTopLevelClass on org/apache/doris/load/loadv2/dpp/ColumnParser.java
    f. suppress OneTopLevelClass on org/apache/doris/load/loadv2/dpp/SparkRDDAggregator.java
    g. suppress LineLength on org/apache/doris/catalog/FunctionSet.java
    h. suppress LineLength on org/apache/doris/common/ErrorCode.java
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels Jun 14, 2022
@morrySnow morrySnow added kind/chore Issues or PRs related to compile and install and removed area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/spark-load Issues or PRs related to the spark load area/routine load labels Jun 14, 2022
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels Jun 14, 2022
@morrySnow morrySnow removed area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/spark-load Issues or PRs related to the spark load area/routine load labels Jun 14, 2022
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels Jun 14, 2022
@github-actions github-actions bot added area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels Jun 17, 2022
@morrySnow morrySnow removed area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/spark-load Issues or PRs related to the spark load area/routine load area/nereids labels Jun 17, 2022
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/nereids area/planner Issues or PRs related to the query planner area/routine load area/spark-load Issues or PRs related to the spark load area/sql/function Issues or PRs related to the SQL functions labels Jun 17, 2022
@morrySnow morrySnow removed area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/spark-load Issues or PRs related to the spark load area/routine load area/nereids labels Jun 17, 2022
morningman
morningman approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

I will quick merge it to avoid conflict

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 17, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit b7b78ae into apache:master Jun 17, 2022
@morrySnow morrySnow deleted the remove_some_rules branch September 7, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. kind/chore Issues or PRs related to compile and install kind/docs Categorizes issue or PR as related to documentation. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] [FE Code Style]step 4: turn on function order and Non-standard writing check
2 participants
@morrySnow @morningman