Skip to content

Commit

Permalink
[Bug](function) use emplace to replace insert_or_assign on stable dis…
Browse files Browse the repository at this point in the history
…tinct (#38776)

## Proposed changes
use emplace to replace insert_or_assign on stable distinct
  • Loading branch information
BiteTheDDDDt authored and dataroaring committed Aug 16, 2024
1 parent 5911aec commit 6b5d0b3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions be/src/vec/aggregate_functions/aggregate_function_distinct.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ struct AggregateFunctionDistinctSingleNumericData {
void add(const IColumn** columns, size_t /* columns_num */, size_t row_num, Arena*) {
const auto& vec = assert_cast<const ColumnVector<T>&>(*columns[0]).get_data();
if constexpr (stable) {
data.insert_or_assign(vec[row_num], data.size());
data.emplace(vec[row_num], data.size());
} else {
data.insert(vec[row_num]);
}
Expand Down Expand Up @@ -170,7 +170,7 @@ struct AggregateFunctionDistinctSingleGenericData
key.data = arena->insert(key.data, key.size);

if constexpr (stable) {
data.insert_or_assign(key, data.size());
data.emplace(key, data.size());
} else {
typename Base::Container::LookupResult it;
bool inserted;
Expand Down Expand Up @@ -214,7 +214,7 @@ struct AggregateFunctionDistinctMultipleGenericData
}

if constexpr (stable) {
data.insert_or_assign(key, data.size());
data.emplace(key, data.size());
} else {
typename Base::Container::LookupResult it;
bool inserted;
Expand Down

0 comments on commit 6b5d0b3

Please sign in to comment.