Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
Gabriel39 committed Nov 20, 2023
1 parent 25b7773 commit 42b7206
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 10 deletions.
3 changes: 0 additions & 3 deletions be/src/pipeline/exec/exchange_sink_operator.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ class ExchangeSinkQueueDependency final : public WriteDependency {
ExchangeSinkQueueDependency(int id, int node_id)
: WriteDependency(id, node_id, "ResultQueueDependency") {}
~ExchangeSinkQueueDependency() override = default;

void* shared_state() override { return nullptr; }
};

class BroadcastDependency final : public WriteDependency {
Expand Down Expand Up @@ -125,7 +123,6 @@ class LocalExchangeChannelDependency final : public WriteDependency {
LocalExchangeChannelDependency(int id, int node_id)
: WriteDependency(id, node_id, "LocalExchangeChannelDependency") {}
~LocalExchangeChannelDependency() override = default;
void* shared_state() override { return nullptr; }
// TODO(gabriel): blocked by memory
};

Expand Down
1 change: 0 additions & 1 deletion be/src/pipeline/exec/exchange_source_operator.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ struct ExchangeDataDependency final : public Dependency {
ExchangeDataDependency(int id, int node_id,
vectorized::VDataStreamRecvr::SenderQueue* sender_queue)
: Dependency(id, node_id, "DataDependency"), _always_done(false) {}
void* shared_state() override { return nullptr; }

void set_always_done() {
_always_done = true;
Expand Down
2 changes: 0 additions & 2 deletions be/src/pipeline/exec/hashjoin_build_sink.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ class SharedHashTableDependency final : public WriteDependency {
SharedHashTableDependency(int id, int node_id)
: WriteDependency(id, node_id, "SharedHashTableDependency") {}
~SharedHashTableDependency() override = default;

void* shared_state() override { return nullptr; }
};

class HashJoinBuildSinkLocalState final
Expand Down
2 changes: 0 additions & 2 deletions be/src/pipeline/exec/result_sink_operator.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ class ResultSinkDependency final : public WriteDependency {
ResultSinkDependency(int id, int node_id)
: WriteDependency(id, node_id, "ResultSinkDependency") {}
~ResultSinkDependency() override = default;

void* shared_state() override { return nullptr; }
};

class ResultSinkLocalState final : public PipelineXSinkLocalState<> {
Expand Down
4 changes: 2 additions & 2 deletions be/src/pipeline/exec/scan_operator.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ class ScanDependency final : public Dependency {
ScanDependency(int id, int node_id)
: Dependency(id, node_id, "ScanDependency"), _scanner_ctx(nullptr) {}

void* shared_state() override { return nullptr; }

// TODO(gabriel):
[[nodiscard]] Dependency* read_blocked_by(PipelineXTask* task) override {
if (_scanner_ctx && _scanner_ctx->get_num_running_scanners() == 0 &&
Expand All @@ -73,6 +71,8 @@ class ScanDependency final : public Dependency {
return Dependency::read_blocked_by(task);
}

bool push_to_blocking_queue() override { return true; }

void block_reading() override {
if (_eos) {
return;
Expand Down

0 comments on commit 42b7206

Please sign in to comment.